Updating the email delivery method

[tomrossi7]

This introduces a new option to the email delivery method to pass in arguments to mailers.

Sometimes a mailer will accept arguments:

class UserMailer < ApplicationMailer
  def comment_notification(comment)
    ...
  end
end

This can now be accounted for with an args option:

class EmailDeliveryWithArguments < Noticed::Base
  deliver_by :email, mailer: "UserMailer", method: :comment_notification, args: :email_args

  def email_args
    comment
  end
end

This will also work with a mailer that accepts named arguments with the named_args option:

class UserMailer < ApplicationMailer
  def comment_notification(comment:)
    ...
  end
end

class EmailDeliveryWithNamedArguments < Noticed::Base
  deliver_by :email, mailer: "UserMailer", method: :comment_notification_with, named_args: :email_named_args

  def email_named_args
    {comment: comment}
  end
end

[tomrossi7]

I'm not sure if we should standardize on args or arguments? I usually don't like to abbreviate, but Its kind of likeparams and parameters?

[tomrossi7]

I added a new mailer action that accepts an argument.

[tomrossi7]

@excid3 in general what do you think about having options that just check if a method is defined rather than passing it as an option? For example, rather than passing the option arguments: :email_arguments to the delivery_by method, what if we just check to see if method_defined?(:email_arguments). This would codify the opinion that if you want to pass in arguments, you must define a method called email_arguments.

class EmailDeliveryWithArguments < Noticed::Base
  deliver_by :email, mailer: "UserMailer", method: :comment_notification_for, arguments: :email_arguments

  def email_arguments
    params[:recipient]
  end
end

would become:

class EmailDeliveryWithArguments < Noticed::Base
  deliver_by :email, mailer: "UserMailer", method: :comment_notification_for

  def email_arguments
    params[:recipient]
  end
end

You lose the flexibility to call the method whatever you want but gain convention-over-configuration goodness. Just a thought!

[excid3]

This is rolled into v2. 👍