-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTML translations. Fixes #310 #311
Conversation
@Spone I think this should do the trick? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Maybe you need to require |
Hmm, looks like this module was added in Rails 7. 🙃 I'm not opposed to making Noticed v2 only support Rails 7+, but we will definitely need a major version to bump the minimum required Rails version. Alternatively, we could rescue from the require and only call super if it exists... which means this feature would only work for Rails 7+, but still can run on Rails 5.2 to 6.1. Tests would have to also check the Rails version accordingly. |
Sounds good! |
Ayyy, there we go. Finally. |
Well shoot. Rafael said it's a private module, so it's not intended to be used like this. I guess we should reimplement ourselves in the gem. |
This allows you to use _html translations that will be automatically marked as HTML safe.
Fixes #310