-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #363
Update README #363
Conversation
Looking good so far! |
One thing I'll ask for clarity on, @excid3. I don't recall if it was required or optional, but we used explicit class NewCommentNotifier < Noticed::Event
deliver_by :email do |config|
config.mailer = "CommentMailer"
config.if = ->(recipient) { !!recipient.preferences[:email] }
end
required_params :record, :foo
end |
Planning on wrapping this up today, btw! |
Sounds good. 👍
|
I think I'm about done here! Massive changes to the README, a few tweaks to the actual library code as prompted by the README.. overall a good turnaround! |
I'll give it a review after the kiddo goes to bed. 👍 |
Snuck in one more commit to add some details to the V2 upgrade guide with the more recent changes 👍 |
Pull Request
Summary:
Still a bit WIP but wanted to pretty significantly revamp the main repo README with the V2 changes
There's still a lot more content to work on, but I at least wanted to get this up!
Related Issue:
n/a
Description:
V2 changed a lot of stuff! Felt like the whole README needed a big look and revamp ❤️
Testing:
n/a
Screenshots (if applicable):
Recommend reading from scratch instead of reading via diffs: https://github.com/jon-sully/noticed/tree/update-readme