Use base_class when specifying recipient_type

[alikrugl]

Pull Request

Summary:
Updates app/models/concerns/noticed/deliverable.rb to ensure it stores the base model class for STI models in the recipient_type column of the polymorphic association.

Related Issue:
Fixed #383

Testing:
All Tests are passing
I have installed the feature in my app and tested it.

Checklist:

• Code follows the project's coding standards
• Tests have been added or updated to cover the changes
• Documentation has been updated (if applicable)
• All existing tests pass
• Conforms to the contributing guidelines

---

This is my first time contributing to open source, so any feedback is appreciated!

[excid3]

I think this will be a good default. I would assume most STI models as recipients will have notifications associated on the base class. However, it's possible that they might not and this would not work in that situation. Those cases can be solved by overriding the recipient_attributes_for method to ignore the base class.

Looks like Rails handles this properly if the has_many :notifications is only defined on the subclass. Nice!

irb> Admin.first.notifications
  Admin Load (0.4ms)  SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT ?  [["LIMIT", 1]]
  Noticed::Notification Load (1.0ms)  SELECT "noticed_notifications".* FROM "noticed_notifications" WHERE "noticed_notifications"."recipient_id" = ? AND "noticed_notifications"."recipient_type" = ? /* loading for pp */ LIMIT ?  [["recipient_id", 1], ["recipient_type", "User"], ["LIMIT", 11]]