Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove record from params with ephemeral notifications #448

Merged
merged 1 commit into from
May 23, 2024

Conversation

excid3
Copy link
Owner

@excid3 excid3 commented May 23, 2024

Ephemeral notifications were extracting record from params. This is done for regular notifications to assign it to the polymorphic association but that is not present with Ephemeral notifications. We can skip that step for Ephemeral notifications and delegate record to the params (this part was already being done).

See #445

@excid3 excid3 added the bug Something isn't working label May 23, 2024
@excid3 excid3 merged commit 2a3dbb0 into main May 23, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant