Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support before_enqueue for bulk delivery methods #463

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

klaaspieter
Copy link
Contributor

Pull Request

Summary:

Add support for canceling bulk delivery methods by raising in before_enqueue

Related Issue:

I didn't create one but I'll do so if necessary.

Description:

I was surprised to find that before_enqueue didn't work for bulk delivery methods. I also couldn't come up with a good reason why it shouldn't work.

Testing:

I added new tests to EventJobTest

Checklist:

  • Code follows the project's coding standards
  • Tests have been added or updated to cover the changes
  • Documentation has been updated (if applicable)
  • All existing tests pass
  • Conforms to the contributing guidelines

@excid3 excid3 merged commit af778b3 into excid3:main Jul 3, 2024
45 checks passed
@klaaspieter klaaspieter deleted the skip-bulk-delivery-method branch August 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants