Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix publishing #32

wants to merge 1 commit into from

Conversation

hukkin
Copy link
Member

@hukkin hukkin commented Oct 16, 2024

There were two reasons why @KyleKing was unable to publish on PyPI:

Copy link
Collaborator

@KyleKing KyleKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for publishing v0.2.0 and taking a look!

- name: Build and publish
run: |
flit publish
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I published mdformat-tables with flit 3.9.0, so there might be an issue with the generated token rather than that flit release:

https://github.com/executablebooks/mdformat-tables/blob/17e79139ed3c288ae8caba84ea834ee2c86c488c/.github/workflows/tests.yml#L90-L98

https://github.com/executablebooks/mdformat-tables/actions/runs/10533763354/job/29190294084
Successfully installed certifi-2024.7.4 charset-normalizer-3.3.2 docutils-0.20.1 flit-3.9.0 flit_core-3.9.0 idna-3.8 requests-2.31.0 tomli-w-1.0.0 urllib3-2.0.7

Would it be worthwhile to try generating a new PyPi token scoped to mdformat-myst before switching to twine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, perhaps it was then just a matter of setting the proper auth ENV variables for flit publish. I tried to flit publish locally and entered credentials when asked for and got the error I linked to in flit's issue tracker. twine worked fine for me.

I think the token should work fine, but it was referred to by the wrong ENV variable name in tests.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants