-
-
Notifications
You must be signed in to change notification settings - Fork 163
Add map and reduce concepts #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
This is great, thanks! I'll probably only have minor suggestions |
I'm thinking maybe the introduction pages could be made smaller. Since the purpose of having a separate Introduction and About page is for the former to contain just enough to get them started, while the About pages are more comprehensive. (This is more of a statement on how thorough you made them than a criticism) |
@bobbicodes would it be good like this? I removed the last two sections of each introduction.md, but kept them in about.md |
Yes, that's perfect :) |
While we are touching things related to these new concepts, it just occurred to me that the tree will be affected significantly due to their introduction. In other words, someone will need to go through the practice exercises in the root I expect there to be a lot of relevant exercises. This could be done in a later PR however. It's kind of a big job because you have to go through each one and decide whether the concept is essential to solving it. |
I might be able to do it, although I think it will take a bit of time. The thing is that I am not familiar with the exercises, since I did very few so far. I'm also a newbie in clojure, which makes it a bit more challenging, although this might not be an issue if I am guided through the PR review process. |
No worries, just thinking ahead :) |
@tasxatzial @bobbicodes do you think this PR could be merged? It contains concepts and exercises for map and reduce, which I believe would be very important to have in the clojure track? |
@JaumeAmoresDS I'll take a look at it later :) |
@JaumeAmoresDS Can you please format using one sentence per line in the Only these two files please because i already have a review in progress about everything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first pass of the review. Includes everything except the introduction.md
and about.md
from the reduce concept.
@JaumeAmoresDS Please take a look and let me know if there are questions.
Given that you created this PR 1.5 year ago, please let me know if you are willing to go through couple rounds of review. If it's too much, I can merge right away and update it in a subsequent PR. No worries. |
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
@tasxatzial I applied your suggestions and changed about.md and introduction.md as requested. Please let me know if this would be ok. |
It seems that you've added extra empty lines. These aren't really needed because they will break paragraphs into multiple lines. That's not what we are after. We want to preserve the existing paragraphs and format the original file with one sentence per line, not the final rendered markdown file. |
Added conceps for higher-order functions map and reduce