Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-ops: Update instructions append #710

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Nov 24, 2024

  • Standardize the first paragraph in the append file
  • Update the wording in both goals

@tasxatzial tasxatzial changed the title Standardize instructions.append list-ops: Update instructions append Nov 24, 2024
@tasxatzial tasxatzial marked this pull request as draft November 24, 2024 23:24
Try to pass the tests by devising a solution that assumes:

- both the input and output are lists instead of vectors
- the test suite isn't modified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite is not modified is a standard of Exercism. Should we need to mention that here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I don't have any other option. The tests are already using vectors as input, and in the first bullet, I ask to assume that they are using lists. Without the second bullet, some folks might be confused, while others might believe that the only way the first assumption can be true is by downloading the exercise and manually changing the tests to use lists, which is definitely not intended. Both bullets are necessary to clarify what I’m explaining in line 22:

These assumptions directly influence the types of the functions that can be used.

This is an optional and slightly more challenging goal. I'm explicitly mentioning more than I usually would to make it a bit clearer how they should approach it without going off on tangents. Still, it assumes a certain level of maturity from the reader, and it's meant only for those who want extra practice.

In any case, the reason I marked this as a draft is to let it sit here while I think about whether I can find an alternative way to phrase the optional goal, or even remove it altogether.

Copy link
Member

@kotp kotp Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could state: as usual, the tests are not meant to be modified, since it is a confirmation that this is not different than other exercises, in this regard.

Otherwise, if I saw this fairly soon after coming to Exercism, it would likely encourage me to change other exercise test files, which is also not intended.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. I'll see how I can rephrase the assumptions. Thanks!

@tasxatzial tasxatzial marked this pull request as ready for review December 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants