fix(complex-numbers): use runner's Catch2 version #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
ahans
force-pushed
the
bugfix/ahans/complex-numbers-catch
branch
2 times, most recently
from
cb8b499 to
2548a8c
Compare
The test runner uses Catch2 v3.4.0, while locally we still had v2.13.6. The recent changes to the complex-numbers test work with v2.13.6, while they don't work with v3.4.0, causing compilation to always fail in the test runner. This commit changes the test to be compatible with v3.4.0 and updates the local Catch2 copy.
ahans
force-pushed
the
bugfix/ahans/complex-numbers-catch
branch
from
2548a8c to
d1c1214
Compare
|
Thanks for taking your time fixing this |
vaeng
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner uses Catch2 v3.4.0, while locally we still had v2.13.6. The recent changes to the complex-numbers test work with v2.13.6, while they don't work with v3.4.0, causing compilation to always fail in the test runner. This commit changes the test to be compatible with v3.4.0 and updates the local Catch2 copy.