Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run configlet lint manually in check_formatting.dart #301

Merged
merged 3 commits into from
Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions bin/check_formatting.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,6 @@ Future main() async {
final CommonUtils utils = CommonUtils();
int errorCode = 0;

if (await utils.fetchConfiglet() == 0) {
print('Checking config.json formatting...');
errorCode = await utils.runCmdIfExecutable('bin/configlet', ['lint', '--track-id', 'dart', '.']);

if (errorCode != 0) {
print('Checking config.json formatting failed!!');
await utils.terminate();
throw StateError('Formatting failed.');
}
}

print('Checking all Dart files formatting...');
errorCode = await utils
.runCmd('pub', ['run', 'dart_style:format', '-i', '0', '-l', '120', '-n', '--set-exit-if-changed', '.']);
Expand Down
3 changes: 2 additions & 1 deletion bin/presubmit.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ Future<Null> main() async {

if (await utils.fetchConfiglet() == 0) {
print('Formatting config.json...');
await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);
print('Unsupported operation: Please see https://github.com/exercism/dart/issues/296');
// await utils.runCmdIfExecutable('bin/configlet', ['fmt', '.']);
}

print('Formatting all Dart files...');
Expand Down
1 change: 1 addition & 0 deletions exercises/concept/futures/lib/futures.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// TODO
1 change: 1 addition & 0 deletions exercises/concept/numbers/lib/numbers.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// TODO
1 change: 1 addition & 0 deletions exercises/concept/strings/lib/strings.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// TODO