Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Map.fetch return value #1352

Conversation

cshintov
Copy link
Contributor

@cshintov cshintov commented Sep 3, 2023

2 => {:ok, 2}

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?
  • Concept changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <concept>/.meta/config.json (see docs)?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

@dabaer
Copy link
Contributor

dabaer commented Sep 4, 2023

Thank you for the PR!

You can't update the /exercises/concept/*/.docs/introduction.md file directly as it is autogenerated from the files in /concepts/.

You'll need to run ./bin/fetch-configlet and ./bin/configlet --generate and commit the results.

@cshintov
Copy link
Contributor Author

cshintov commented Sep 4, 2023

That's what I did!

I first edited concepts/structs/introduction.md and then did this:

You'll need to run ./bin/fetch-configlet and ./bin/configlet generate and commit the results.

Copy link
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂 the same error appears in the file concepts/structs/about.md, could you fix it there too?

`2` => `{:ok, 2}`
@cshintov cshintov force-pushed the fix/concepts-structs-Map.fetch-return-value branch from b0def1b to 1dfa9aa Compare September 4, 2023 15:20
@cshintov
Copy link
Contributor Author

cshintov commented Sep 4, 2023

Done.

I re-ran the configlet generate again. But it didn't have any effect this time.

@angelikatyborska
Copy link
Member

That's correct, only introduction files are affected by the autogeneration. Thank you!

@angelikatyborska angelikatyborska merged commit 4068d55 into exercism:main Sep 5, 2023
@cshintov cshintov deleted the fix/concepts-structs-Map.fetch-return-value branch September 5, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants