Add practice exercise ledger
#1367
Conversation
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
| @type entry :: %{amount_in_cents: integer(), date: Date.t(), description: String.t()} | ||
|
|
||
| @spec format_entries(currency(), String.t(), list(entry())) :: String.t() | ||
| def format_entries(currency, locale, entries) do |
There was a problem hiding this comment.
Maybe the locale could also get its own custom type?
There was a problem hiding this comment.
I thought about it, I think I decided not to because somehow I thought capital letter were not allowed in atoms... But that's silly, so I made it a type after all :)
| """ | ||
| Date | Description | Change\s\s\s\s\s\s\s | ||
| 01/01/2015 | Freude schoner Gotterf... | ($1,234.56) | ||
| """ |
There was a problem hiding this comment.
Did you mean for the boilerplate solution to be failing this test? In the markdown exercise, the boilerplate passes all tests.
There was a problem hiding this comment.
My bad! I made a value wrong on purpose, but I made it too wrong and somehow forgot to check :(
It has been a while since I added an exercise :)
This one got tests added a while back.
It's a refactor exercise, it was my first time doing it, I don't know if I went too far with the bad code.
Some pieces of the code would only work on the given test cases, is that fair game?