Fix AllYourBase to follow problem specs

[pedrosnk]

For All your base exercise, we need it's valid to return input or output error when both are provided. This commit allows both to be returned from the tested function.

Because we are expecting an error to be either input or output, I'm using a regex on the tests to match any of the errors to be valid.

[github-actions]

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

• General steps

  • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

• Any exercise changed

  • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
  • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
  • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?

• Practice exercise changed

  • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
  • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

• Practice exercise tests changed

  • ⚪️ Are all tests except the first one skipped?
  • 📜 Does <exercise>/.meta/tests.toml need updating?

---

Automated comment created by PR Commenter 🤖.

[angelikatyborska]

Thank you for bringing this to my attention! Actually according to the Exercism-wide problem specifications, the error should be "input base must be >= 2" in case both input and output bases are negative (see https://github.com/exercism/problem-specifications/blob/main/exercises/all-your-base/canonical-data.json#L251-L263).

Could you modify your PR to follow that expectation?

[pedrosnk]

TIL about the problem-specifications repo. In fact I don't believe there's much to change on the the tests if the specification must be followed.

Would make sense to update the elixir instructions following the error specification?

[angelikatyborska]

Would make sense to update the elixir instructions following the error specification?

You mean the file exercises/practice/all-your-base/.docs/instructions.md? That file is copied from problem specifications word for word and cannot be changed.

What we need is a single word change in the test file (compared to before your initial changes), to change the error message from output to input, and then a change in the file exercises/practice/all-your-base/.meta/example.ex so that the example solution passes the changed tests.

[pedrosnk]

I follow you now, sorry, I thought it was already correct.

Thanks for walking me through it. Just patched the correct fix.

[pedrosnk]

test was failing because exercises/practice/all-your-base/.meta/example.ex needed to be updated. Just update it and rerun bin/ci.sh on my local machine. Seems to be passing now.

[angelikatyborska]

Thank you!