Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync word count with canonical tests #1381

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jonathan-h-grebe
Copy link
Contributor

Summary

This PR syncs the tests for word-count with the canonical data by

  • removing tests whose requirements contradict the problem specification as described in instructions.md
    • "hyphens" - this required the solution to treat words containing a hyphen as single words, whereas the instructions state "The only punctuation that does not separate words is the apostrophe in contractions."
    • "German" - this required the solution to handle German script characters, whereas the instructions state "The subtitles from these dramas use only ASCII characters."
    • "Polish - same as with German
  • eliminating test description inconsistencies. eg change "count one of each" to "count one of each word"

References

discussion on forum

@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@@ -82,7 +76,7 @@ defmodule WordCountTest do
end

@tag :pending
test "with quotations at the end at the beginning of the sentence" do
test "with quotations at the end and beginning of the sentence" do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelikatyborska Strictly speaking this change lands outside the scope of the problem this PR aims to fix, but since it is very minor I thought I'd try including it anyway.

I couldn't understand the text here, and from the contents of the test it looked like a typo.
I'm assuming what I've changed it to matches the intention of the test, but please tell me if I'm wrong!

@jonathan-h-grebe jonathan-h-grebe marked this pull request as draft October 17, 2023 13:52
@jonathan-h-grebe jonathan-h-grebe marked this pull request as ready for review October 17, 2023 14:02
Copy link
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🙏 thank you

@angelikatyborska angelikatyborska merged commit 3121b6e into exercism:main Oct 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants