Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leap 48in24 approaches #1401
Leap 48in24 approaches #1401
Changes from 7 commits
c4108ab
630a266
d4084e0
2b8ec47
616f6ec
0a4fddc
5038fcb
0e16a73
0d19aa2
54a79e1
3c81c2c
09d55ca
085dfa3
6e85e4f
5eb7841
510c33c
fc4a44c
f98d44f
b9bd559
431da1d
deb494f
ff5bc09
8db3e1e
0754b52
33e7fc6
a930e7f
06d05d2
19a3bb6
6e527c7
16f7034
5c8503c
a2172ae
5a8d670
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I think there are no test cases for the year
0
, so we could also say:(I'm specifying "input numbers" instead of just "numbers" to avoid people complaining that technically there is a zero in this exercise, in
rem(year, n) == 0
😛 )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the "non-negative" here very intentionally. Positives start at 1, non-negative start at 0, so the zero is included. Probably a better name for the
n
parameter and for the description would be to say 'divisor' as this is technically what it is, and where the behaviour of the two functions differ.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, no problem, we can keep it