Extend test for log-parser

[hrubi]

I have seen several "Community Solutions" for this exercise which were not correct:

def valid_line?(line) do
line =~ ~r/^[DEBUG|INFO|WARNING|ERROR]/
end

This would yield wrong result for some lines, which are now covered by the test.

[github-actions]

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

• General steps

  • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

• Any exercise changed

  • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
  • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
  • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?

• Concept exercise changed

  • 🌲 Do prerequisites and practices in config.json need to be updated?
  • 📖 Does the concept introduction provide all necessary information to solve this exercise?

• Concept exercise tests changed

  • ⚪️ Are all tests un-skipped?
  • 🔢 Are all tests annotated with @tag task_id?
  • 🐈 Can all tests be understood by reading the test's block only (e.g. no module attributes, no setup functions)?

---

Automated comment created by PR Commenter 🤖.

[angelikatyborska]

Thank you for pointing this out 🙏

I think adding 4 separate tests for this is a bit of an overkill, so I would prefer to extend the existing test case with a few more examples, like this:

    @tag task_id: 1
    test "level must be wrapped in square brackets" do
      assert LogParser.valid_line?("ERROR something really bad happened") == false
      assert LogParser.valid_line?("[INFO the latest information") == false
      assert LogParser.valid_line?("DEBUG] response time 3ms") == false
    end

That should be enough to catch most of those flawed community solutions, right?

[hrubi]

I agree, thanks .

[angelikatyborska]

Thanks again!