Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange dead link for 'with' #1485

Merged
merged 2 commits into from
May 26, 2024
Merged

Exchange dead link for 'with' #1485

merged 2 commits into from
May 26, 2024

Conversation

angelikatyborska
Copy link
Member

This was the original: https://web.archive.org/web/20150511141513/http://twitter.com/@Joseph_Kain

It's from 2015 and talks about version 1.2 being upcoming 😁 maybe not the best message for beginners. So I decided against linking to its wayback machine copy, and just find a new link.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Concept changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <concept>/.meta/config.json (see docs)?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

This was the original: https://web.archive.org/web/20150511141513/http://twitter.com/@Joseph_Kain

I don't see anything there.

Anyway, the new link is fine.
How would you feel about adding this link https://hexdocs.pm/elixir/main/code-anti-patterns.html#complex-else-clauses-in-with ?
Mentioning an anti-pattern while people are still learning seems like a good idea

@angelikatyborska
Copy link
Member Author

Sorry, I accidentally linked to the guy's twitter account. That was the original: https://web.archive.org/web/20221206143050/http://learningelixir.joekain.com/learning-elixir-with/

@angelikatyborska angelikatyborska merged commit 8199541 into main May 26, 2024
10 checks passed
@angelikatyborska angelikatyborska deleted the dead-link-with branch May 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants