-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Elixir 1.17 #1495
Update to Elixir 1.17 #1495
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,7 +134,7 @@ defmodule SgfParsing do | |
with {:ok, result, rest} <- some(parser).(input) do | ||
{:ok, result, rest} | ||
else | ||
{:error, _err, ^input} -> {:ok, [], input} | ||
{:error, _err, rest} when rest == input -> {:ok, [], input} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one seems like a bug (in Elixir or OTP) to be honest, I'll try to reproduce on something simpler and check. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was fixed in 1.17.1: https://github.com/elixir-lang/elixir/releases/tag/v1.17.1
Since this is just in an example file, I'm fine completely ignoring this issue (meaning: doing the change you're suggesting to the example file and that's it) |
||
err -> err | ||
end | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.16 gives
[{:..., [line: 3], nil}]
but 1.17 gives[{:..., [line: 3], []}]
so I needed to change the test to accept both versions.The 1.17 changelog mentions in the debug section
So that must be part of it.
Does that need a comment?
There could also be other ways of fixing it, for example quoting
...
and shoving it in the expected value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current way is the simplest way of resolving the problem