Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation problems identified in issue 589 #591

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix documentation problems identified in issue 589 #591

merged 1 commit into from
Aug 31, 2023

Conversation

ceddlyburge
Copy link
Contributor

@ceddlyburge ceddlyburge mentioned this pull request Aug 30, 2023
Closed
mpizenberg
mpizenberg approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cedd, those changes look good to me. Why are the tests not passing?

@ceddlyburge
Copy link
Contributor Author

ceddlyburge commented Aug 30, 2023 •
edited
Loading

Looks like the tests are passing to me? The tests are still flaky, there is an outstanding issue to look in to it, so I think they failed the first time and passed the second time ...

#543

@mpizenberg
Copy link
Member

Yep, I restarted the failing test and it passed.

@ceddlyburge ceddlyburge merged commit e0a6bcd into main Aug 31, 2023
@ceddlyburge ceddlyburge deleted the top-scorers-exemplar branch August 31, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpizenberg mpizenberg mpizenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor typo in the Learning exercise Top Scores
2 participants
@ceddlyburge @mpizenberg