Incorporate review comment.

exercism · Feb 16, 2024 · 88f7009 · 88f7009
1 parent 38114c0
commit 88f7009
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/exercises/practice/satellite/.meta/examples/success-standard/src/Satellite.hs b/exercises/practice/satellite/.meta/examples/success-standard/src/Satellite.hs
@@ -3,13 +3,13 @@ module Satellite (treeFromTraversals) where
 import Data.Tree ( Tree(Node) )
 import Data.Set (fromList, size)
 
-treeFromTraversals :: String -> String -> Maybe (Tree Char)
+treeFromTraversals :: Ord a => [a] -> [a] -> Maybe (Tree a)
 treeFromTraversals preorder inorder =
   if (not.null) preorder && length preorder == size (fromList preorder)
   then treeFromTraversals' preorder inorder
   else Nothing
 
-treeFromTraversals' :: String -> String -> Maybe (Tree Char)
+treeFromTraversals' :: Ord a => [a] -> [a] -> Maybe (Tree a)
 treeFromTraversals' preorder inorder = Node root <$> sequence (leftChild <> rightChild)
   where
     root = head preorder

diff --git a/exercises/practice/satellite/src/Satellite.hs b/exercises/practice/satellite/src/Satellite.hs
@@ -2,5 +2,5 @@ module Satellite (treeFromTraversals) where
 
 import Data.Tree (Tree)
 
-treeFromTraversals :: String -> String -> Maybe (Tree Char)
+treeFromTraversals :: Ord a => [a] -> [a] -> Maybe (Tree a)
 treeFromTraversals preorder inorder = error "You need to implement this function."