Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tests for practice exercise knapsack #2661

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

manumafe98
Copy link
Contributor

@manumafe98 manumafe98 commented Jan 22, 2024

pull request

This issue addresses: #2388

This exercise does not need any change only the update of the tests.toml, The test already have an empty list instead of an empty item.

$ bin/configlet sync --tests --update --exercise knapsack
Updating cached 'problem-specifications' data...
Checking exercises...
[warn] knapsack: missing 1 test case
The following test case is missing:
{
  "uuid": "3993a824-c20e-493d-b3c9-ee8a7753ee59",
  "reimplements": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
  "description": "no items",
  "property": "maximumValue",
  "input": {
    "maximumWeight": 100,
    "items": []
  },
  "expected": 0
}

It reimplements this test case:
{
  "uuid": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
  "description": "no items",
  "property": "maximumValue",
  "input": {
    "maximumWeight": 100,
    "items": {}
  },
  "expected": 0
}

Reviewer Resources:

Track Policies

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it looks like the test was reimplemented because the previous version used {} for the list of items instead of []. 👍

@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Jan 23, 2024
@sanderploegsma sanderploegsma merged commit a17acae into exercism:main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants