Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase difficulty of the word-count exercise #1929

Conversation

TomPradat
Copy link
Contributor

@TomPradat TomPradat commented Oct 2, 2022

As discussed here. The exercise encourages the use of regex, which is far from trivial IMO

An hacktoberfest label would be awesome 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@TomPradat TomPradat marked this pull request as ready for review October 2, 2022 19:26
@SleeplessByte SleeplessByte added hacktoberfest-accepted Opt-in to hacktoberfest x:rep/tiny Tiny amount of reputation labels Oct 3, 2022
@SleeplessByte SleeplessByte merged commit 5295c4b into exercism:main Oct 3, 2022
@TomPradat TomPradat deleted the feature/TP/increase-word-count-difficulty branch October 3, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants