Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync clock #863

Merged
merged 9 commits into from
Dec 21, 2024
Merged

sync clock #863

merged 9 commits into from
Dec 21, 2024

Conversation

tomasnorre
Copy link
Contributor

Resolves #845

@github-actions GitHub Actions
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@tomasnorre tomasnorre added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 17, 2024
@tomasnorre tomasnorre marked this pull request as ready for review November 17, 2024 14:47
@tomasnorre
fix: Ensure name_filter are local scoped (exercism#861)
a6109a3 
* fix: Ensure name_filter are local scoped

* fix test on macos
@tomasnorre tomasnorre requested a review from mk-mxp November 19, 2024 11:26
mk-mxp
mk-mxp requested changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should have a comment in the students stub that missing methods need to be added.

exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
mk-mxp
mk-mxp requested changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not connected to the discussion about the magic method usage.

Please add a comment to the students stub, that all missing methods need to be added by the student.

exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
exercises/practice/clock/ClockTest.php Outdated Show resolved Hide resolved
mk-mxp
mk-mxp approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

exercises/practice/clock/Clock.php Show resolved Hide resolved
@mk-mxp mk-mxp merged commit ce13a53 into exercism:main Dec 21, 2024
12 checks passed
@tomasnorre tomasnorre deleted the sync-clock branch December 21, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

@homersimpsons homersimpsons Awaiting requested review from homersimpsons

Assignees

@tomasnorre tomasnorre

Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync clock
3 participants
@tomasnorre @homersimpsons @mk-mxp