Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example.sml relative path #241

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Update example.sml relative path #241

merged 1 commit into from
Nov 1, 2023

Conversation

BNAndras
Copy link
Member

No description provided.

@rainij
Copy link
Contributor

rainij commented Oct 31, 2023

@BNAndras Looks correct to me, but to be honest it is a long time ago when I looked into how the config.json works or what exactly it is responsible for. Can you provide some explanation how this came to your attention? Was something broken? When I did some PRs in this repo (a while ago) I didn't notice this.

Alternatively you could just ask somebody else to review this.

@BNAndras
Copy link
Member Author

https://github.com/exercism/sml/actions/runs/6564423719/job/17830751975

configlet lint complains if an exercise's example.sml is not in the expected relative location referenced in the files array in the track's config. This must have been a recent change in the last few months since https://github.com/exercism/sml/actions/runs/5554101355 also failed recently but PRs back in April were fine. I suspect before this change, configlet assumed the example.sml was in .meta so you were providing the file's location relative to .meta. In that case, it's probably now looking for example.sml relative to the exercise slug folder which is why we need to prefix the .meta folder path.

Copy link
Contributor

@rainij rainij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BNAndras thanks for your explanations. I understand now.

Can you merge it, or should I do it?

@BNAndras
Copy link
Member Author

BNAndras commented Nov 1, 2023

I don’t have write access to this repo unfortunately.

@rainij rainij merged commit 56c21a1 into exercism:main Nov 1, 2023
2 checks passed
@BNAndras BNAndras deleted the patch-2 branch November 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants