Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vitest configuration and logging enhancements for sensitive data #1570

Merged
merged 10 commits into from
Feb 9, 2025
Merged

Add Vitest configuration and logging enhancements for sensitive data #1570

merged 10 commits into from
Feb 9, 2025

Conversation

juan871003
Copy link
Contributor

Added a custom callback function to graphweaverMetadata.addMutation to log any incoming queries taking care of possible personal data that should be obfuscated.

thekevinbrown
thekevinbrown requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@thekevinbrown thekevinbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm concerned about here is the potential double parsing of the GraphQL. Apollo should be doing the parsing for us and should be passing us an AST as far as I'm aware.

src/packages/auth/src/authentication/methods/utils.ts Outdated Show resolved Hide resolved
src/packages/auth/src/authentication/methods/utils.ts Outdated Show resolved Hide resolved
src/packages/auth/src/authentication/methods/utils.ts Outdated Show resolved Hide resolved
@thekevinbrown thekevinbrown merged commit 7817bb1 into main Feb 9, 2025
14 checks passed
@thekevinbrown thekevinbrown deleted the feat/add-logOnDidResolveOperation-for-custom-logging branch February 9, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekevinbrown thekevinbrown thekevinbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan871003 @thekevinbrown