Fix: Pagination on Admin UI for some backend providers #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, set defaults for mikroORM providers
…g on comparison flag
mackcheesman
changed the title
thekevinbrown
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Admin UI uses a pseudo-cursor for pagination, and to avoid duplicate records that would appear when something gets created or deleted if paging with limit/offset, it instead uses comparison with the last record on the last page to get the next page.
We discovered that this doesn't work as expected for some providers, because they don't support comparing string ID fields. This PR adds a flag to
BackendProviderConfigfor if comparison is supported or not by the provider (false by default). This is set true for all the built-in MikroORM providers. The Admin UI queries for this flag and changes how it paginates accordingly.