Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich text editor support with example #1594

Merged
merged 18 commits into from
Feb 21, 2025
Merged

Add rich text editor support with example #1594

merged 18 commits into from
Feb 21, 2025

Conversation

juan871003
Copy link
Contributor

@juan871003 juan871003 commented Feb 17, 2025

image

by

image

Copy link
Member

@thekevinbrown thekevinbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things that I think will make this more maintainable, but it's looking great so far!

const handleBoldClick = (event: React.MouseEvent<HTMLButtonElement>) => {
event.preventDefault();
event.stopPropagation();
editor.chain().focus().toggleBold().run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below, I think we can remove most of this duplication.

@thekevinbrown thekevinbrown changed the title Add markdown support with example Add rich text editor support with example Feb 20, 2025
@thekevinbrown thekevinbrown merged commit 19dfd2d into main Feb 21, 2025
14 checks passed
@thekevinbrown thekevinbrown deleted the markdown-input branch February 21, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants