Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Leader election #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Leader election #31

wants to merge 2 commits into from

Conversation

VukW
Copy link
Contributor

@VukW VukW commented May 31, 2017

Here is restored old file about leader selection. It needs review and comments to be changed accordingly to other documentation style

Viacheslav Kukushkin added 2 commits May 31, 2017 04:47
@VukW VukW requested a review from slowli May 31, 2017 01:59
# Leader Election
# Leader Election algorithm

This page describes the problem and solution for the problem of leader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem ... problem
It seems that the intro from the blog was better

`1 block out of F+1 blocks` is guaranteed to be mined by honest miners
(instead of `sufficient fraction of K blocks`).*

## Round Robin overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round Robin -> Leader Election everythere

Round Robin algorithm defines how the order of validating nodes for the
height `H` should be calculated. Such order determines node's `block
proposal` priority. That is, block proposal from node #2 would be
accepted only if `block proposal` from node #1 was absent. ## Algorithm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## -> \n ##

selection. To remove any centrality point, Exonum needs make block
generation distibuted. The proposed algorithm is revealed here.

## Solvable problem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solvable problem or problems?

This section is also better written in blog

Due to this property, byzantine nodes would not follow one after the
other in a series but would be randomly interspersed with fair nodes.

## Round Robin details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is also better written in blog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really the implemented algorithm from Exonum?

accepted only if `block proposal` from node #1 was absent. ## Algorithm
properties

The properties that are provided by the current algorithm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is rather surprising to see properties before the algorithm description

Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review as of adc3e00. The text should be restructured as follows:

  • Short intro
  • Description of what is actually accomplished in Exonum Core and how it can be configured/extended
  • Motivation: why is the leader election algorithm needed and what security properties it yields
  • Maybe, unsolved problems iff we will solve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants