FIX THE GOLINT

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>

cmd/dbaas_create.go

@@ -79,7 +79,7 @@ type dbaasServiceCreateCmd struct {
 	MysqlMigrationPassword     string   `cli-flag:"mysql-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	MysqlMigrationSSL          bool     `cli-flag:"mysql-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	MysqlMigrationUsername     string   `cli-flag:"mysql-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	MysqlMigrationDbName       string   `cli-flag:"mysql-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	MysqlMigrationDBName       string   `cli-flag:"mysql-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	MysqlMigrationMethod       string   `cli-flag:"mysql-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	MysqlMigrationIgnoreDbs    []string `cli-flag:"mysql-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 	MysqlBinlogRetentionPeriod int64    `cli-flag:"mysql-binlog-retention-period" cli-usage:"the minimum amount of time in seconds to keep binlog entries before deletion" cli-hidden:""`
@@ -100,7 +100,7 @@ type dbaasServiceCreateCmd struct {
 	PGMigrationPassword  string   `cli-flag:"pg-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	PGMigrationSSL       bool     `cli-flag:"pg-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	PGMigrationUsername  string   `cli-flag:"pg-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	PGMigrationDbName    string   `cli-flag:"pg-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	PGMigrationDBName    string   `cli-flag:"pg-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	PGMigrationMethod    string   `cli-flag:"pg-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	PGMigrationIgnoreDbs []string `cli-flag:"pg-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 
@@ -114,7 +114,7 @@ type dbaasServiceCreateCmd struct {
 	RedisMigrationPassword  string   `cli-flag:"redis-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	RedisMigrationSSL       bool     `cli-flag:"redis-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	RedisMigrationUsername  string   `cli-flag:"redis-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	RedisMigrationDbName    string   `cli-flag:"redis-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	RedisMigrationDBName    string   `cli-flag:"redis-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	RedisMigrationMethod    string   `cli-flag:"redis-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	RedisMigrationIgnoreDbs []string `cli-flag:"redis-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 }

cmd/dbaas_create_mysql.go

@@ -100,7 +100,7 @@ func (c *dbaasServiceCreateCmd) createMysql(_ *cobra.Command, _ []string) error
 			Port:     c.MysqlMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.MysqlMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.MysqlMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.MysqlMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.MysqlMigrationDBName),
 		}
 		if c.MysqlMigrationSSL {
 			databaseService.Migration.Ssl = &c.MysqlMigrationSSL

cmd/dbaas_create_pg.go

@@ -125,7 +125,7 @@ func (c *dbaasServiceCreateCmd) createPG(_ *cobra.Command, _ []string) error {
 			Port:     c.PGMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.PGMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.PGMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.PGMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.PGMigrationDBName),
 		}
 		if c.PGMigrationSSL {
 			databaseService.Migration.Ssl = &c.PGMigrationSSL

cmd/dbaas_create_redis.go

@@ -76,7 +76,7 @@ func (c *dbaasServiceCreateCmd) createRedis(_ *cobra.Command, _ []string) error
 			Port:     c.RedisMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.RedisMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.RedisMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.RedisMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.RedisMigrationDBName),
 		}
 		if c.RedisMigrationSSL {
 			databaseService.Migration.Ssl = &c.RedisMigrationSSL

cmd/dbaas_update.go

@@ -69,7 +69,7 @@ type dbaasServiceUpdateCmd struct {
 	MysqlMigrationPassword     string   `cli-flag:"mysql-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	MysqlMigrationSSL          bool     `cli-flag:"mysql-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	MysqlMigrationUsername     string   `cli-flag:"mysql-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	MysqlMigrationDbName       string   `cli-flag:"mysql-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	MysqlMigrationDBName       string   `cli-flag:"mysql-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	MysqlMigrationMethod       string   `cli-flag:"mysql-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	MysqlMigrationIgnoreDbs    []string `cli-flag:"mysql-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 	MysqlBinlogRetentionPeriod int64    `cli-flag:"mysql-binlog-retention-period" cli-usage:"the minimum amount of time in seconds to keep binlog entries before deletion" cli-hidden:""`
@@ -85,7 +85,7 @@ type dbaasServiceUpdateCmd struct {
 	PGMigrationPassword  string   `cli-flag:"pg-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	PGMigrationSSL       bool     `cli-flag:"pg-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	PGMigrationUsername  string   `cli-flag:"pg-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	PGMigrationDbName    string   `cli-flag:"pg-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	PGMigrationDBName    string   `cli-flag:"pg-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	PGMigrationMethod    string   `cli-flag:"pg-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	PGMigrationIgnoreDbs []string `cli-flag:"pg-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 
@@ -97,7 +97,7 @@ type dbaasServiceUpdateCmd struct {
 	RedisMigrationPassword  string   `cli-flag:"redis-migration-password" cli-usage:"password for authenticating to the source server" cli-hidden:""`
 	RedisMigrationSSL       bool     `cli-flag:"redis-migration-ssl" cli-usage:"connect to the source server using SSL" cli-hidden:""`
 	RedisMigrationUsername  string   `cli-flag:"redis-migration-username" cli-usage:"username for authenticating to the source server" cli-hidden:""`
-	RedisMigrationDbName    string   `cli-flag:"redis-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
+	RedisMigrationDBName    string   `cli-flag:"redis-migration-dbname" cli-usage:"database name for bootstrapping the initial connection" cli-hidden:""`
 	RedisMigrationMethod    string   `cli-flag:"redis-migration-method" cli-usage:"migration method to be used (\"dump\" or \"replication\")" cli-hidden:""`
 	RedisMigrationIgnoreDbs []string `cli-flag:"redis-migration-ignore-dbs" cli-usage:"list of databases which should be ignored during migration" cli-hidden:""`
 }

cmd/dbaas_update_mysql.go

@@ -101,7 +101,7 @@ func (c *dbaasServiceUpdateCmd) updateMysql(cmd *cobra.Command, _ []string) erro
 			Port:     c.MysqlMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.MysqlMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.MysqlMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.MysqlMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.MysqlMigrationDBName),
 		}
 		if c.MysqlMigrationSSL {
 			databaseService.Migration.Ssl = &c.MysqlMigrationSSL

cmd/dbaas_update_pg.go

@@ -125,7 +125,7 @@ func (c *dbaasServiceUpdateCmd) updatePG(cmd *cobra.Command, _ []string) error {
 			Port:     c.PGMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.PGMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.PGMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.PGMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.PGMigrationDBName),
 		}
 		if c.PGMigrationSSL {
 			databaseService.Migration.Ssl = &c.PGMigrationSSL

cmd/dbaas_update_redis.go

@@ -84,7 +84,7 @@ func (c *dbaasServiceUpdateCmd) updateRedis(cmd *cobra.Command, _ []string) erro
 			Port:     c.RedisMigrationPort,
 			Password: utils.NonEmptyStringPtr(c.RedisMigrationPassword),
 			Username: utils.NonEmptyStringPtr(c.RedisMigrationUsername),
-			Dbname:   utils.NonEmptyStringPtr(c.RedisMigrationDbName),
+			Dbname:   utils.NonEmptyStringPtr(c.RedisMigrationDBName),
 		}
 		if c.RedisMigrationSSL {
 			databaseService.Migration.Ssl = &c.RedisMigrationSSL

cmd/iam_role_show.go

@@ -57,7 +57,7 @@ func (c *iamRoleShowCmd) cmdPreRun(cmd *cobra.Command, args []string) error {
 
 func (c *iamRoleShowCmd) cmdRun(_ *cobra.Command, _ []string) error {
 	if c.Role == "" {
-		return errors.New("Role ID not provided")
+		return errors.New("Role ID not provided") //nolint: stylecheck
 	}
 
 	zone := account.CurrentAccount.DefaultZone

cmd/iam_role_update.go

@@ -49,7 +49,7 @@ func (c *iamRoleUpdateCmd) cmdPreRun(cmd *cobra.Command, args []string) error {
 
 func (c *iamRoleUpdateCmd) cmdRun(cmd *cobra.Command, _ []string) error {
 	if c.Role == "" {
-		return errors.New("Role not provided")
+		return errors.New("Role not provided") // nolint:stylecheck
 	}
 
 	zone := account.CurrentAccount.DefaultZone

cmd/instance_pool_delete.go

@@ -59,8 +59,8 @@ func (c *instancePoolDeleteCmd) cmdRun(_ *cobra.Command, _ []string) error {
 	for _, nlb := range nlbs {
 		for _, svc := range nlb.Services {
 			if svc.InstancePoolID == instancePool.ID {
-				return fmt.Errorf(
-					"Instance Pool %q is still referenced by NLB service %s/%s", // nolint:golint
+				return fmt.Errorf( // nolint:stylecheck
+					"Instance Pool %q is still referenced by NLB service %s/%s",
 					*instancePool.Name,
 					*nlb.Name,
 					*svc.Name,

cmd/instance_snapshot_create.go

@@ -54,7 +54,7 @@ func (c *instanceSnapshotCreateCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		snapshot, err = globalstate.EgoscaleClient.CreateInstanceSnapshot(ctx, c.Zone, instance)
 		if err != nil {
 			if errors.Is(err, context.DeadlineExceeded) {
-				err = fmt.Errorf("Request timeout reached. Snapshot creation is not canceled and might still be running, check the status with: exo c i snapshot list")
+				err = fmt.Errorf("Request timeout reached. Snapshot creation is not canceled and might still be running, check the status with: exo c i snapshot list") // nolint:stylecheck
 			}
 			return
 		}

cmd/sks_nodepool_delete.go

@@ -65,7 +65,7 @@ func (c *sksNodepoolDeleteCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		}
 	}
 
-	return errors.New("Nodepool not found") // nolint:golint
+	return errors.New("Nodepool not found") // nolint:stylecheck
 }
 
 func init() {

cmd/sks_nodepool_evict.go

@@ -81,7 +81,7 @@ func (c *sksNodepoolEvictCmd) cmdRun(cmd *cobra.Command, _ []string) error {
 		}
 	}
 	if nodepool == nil {
-		return errors.New("Nodepool not found") // nolint:golint
+		return errors.New("Nodepool not found") // nolint:stylecheck
 	}
 
 	nodes := make([]string, len(c.Nodes))

cmd/sks_nodepool_scale.go

@@ -78,7 +78,7 @@ func (c *sksNodepoolScaleCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		}
 	}
 	if nodepool == nil {
-		return errors.New("Nodepool not found") // nolint:golint
+		return errors.New("Nodepool not found") // nolint:stylecheck
 	}
 
 	decorateAsyncOperation(fmt.Sprintf("Scaling Nodepool %q...", c.Nodepool), func() {

cmd/sks_nodepool_show.go

@@ -91,7 +91,7 @@ func (c *sksNodepoolShowCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		}
 	}
 	if nodepool == nil {
-		return errors.New("Nodepool not found") // nolint:golint
+		return errors.New("Nodepool not found") // nolint:stylecheck
 	}
 
 	out := sksNodepoolShowOutput{

cmd/sks_nodepool_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	egoscale "github.com/exoscale/egoscale/v2"
+
 	"github.com/stretchr/testify/require"
 )
 

cmd/sks_nodepool_update.go

@@ -77,7 +77,7 @@ func (c *sksNodepoolUpdateCmd) cmdRun(cmd *cobra.Command, _ []string) error { //
 		}
 	}
 	if nodepool == nil {
-		return errors.New("Nodepool not found") // nolint:golint
+		return errors.New("Nodepool not found") // nolint:stylecheck
 	}
 
 	if cmd.Flags().Changed(mustCLICommandFlagName(c, &c.AntiAffinityGroups)) {

pkg/flags/version_filters.go

@@ -107,7 +107,7 @@ func doesVersionMatch(ovi object.ObjectVersionInterface, matchVersions []string)
 			}
 		}
 
-		if *ovi.GetVersionId() == version {
+		if *ovi.GetVersionID() == version {
 			return true
 		}
 	}

pkg/status/status.go

@@ -44,7 +44,7 @@ func (s StatusPalStatus) GetStatusByZone() ([][]string, error) {
 // - Parent services = Global and all the zones
 // - Child services = products available in a zone or globally
 type Service struct {
-	Id   *int    `json:"id,omitempty"`
+	ID   *int    `json:"id,omitempty"`
 	Name *string `json:"name,omitempty"`
 
 	// The type of the current incident:
@@ -72,7 +72,7 @@ func (s *Service) getIncidentType() string {
 
 // Active Maintenance or Incident
 type Event struct {
-	Id    *int    `json:"id,omitempty"`
+	ID    *int    `json:"id,omitempty"`
 	Title *string `json:"title,omitempty"`
 	// The time at which the incident/maintenance started(UTC).
 	StartsAt *string `json:"starts_at"`
@@ -97,7 +97,7 @@ func (e Events) GetActiveEvents(services Services) ([][]string, error) {
 			if services.IsParentService(impacted) {
 				continue
 			}
-			svcName, err := services.GetServiceNamebyId(impacted)
+			svcName, err := services.GetServiceNamebyID(impacted)
 			if err != nil {
 				return nil, err
 			}
@@ -127,7 +127,7 @@ type Services []Service
 // We have 2 levels of services, check if a service is a parent
 func (s Services) IsParentService(id int) bool {
 	for _, service := range s {
-		if service.Id != nil && *service.Id == id {
+		if service.ID != nil && *service.ID == id {
 			return true
 		}
 	}
@@ -136,17 +136,17 @@ func (s Services) IsParentService(id int) bool {
 }
 
 // Return the Zone and the impacted service = fullname (parent svc + child svc)
-func (s Services) GetServiceNamebyId(id int) (string, error) {
+func (s Services) GetServiceNamebyID(id int) (string, error) {
 	// For all zones / global services
 	for _, parentService := range s {
 		// id provided is a parent service, return the name
-		if *parentService.Id == id {
+		if *parentService.ID == id {
 			return *parentService.Name, nil
 		}
 		// Try to find the Service Id in the child services
 		for _, childService := range parentService.Children {
 			// In this case, we returen the Parent and the Child names
-			if *childService.Id == id {
+			if *childService.ID == id {
 				return *parentService.Name + " " + *childService.Name, nil
 			}
 		}

pkg/status/status_test.go

@@ -118,10 +118,10 @@ func TestStatusPageNoEvent(t *testing.T) {
 	assert.Equal(t, false, statusPageTest.Services.IsParentService(11))
 
 	// Check ServiceName contains Parent
-	name, err := statusPageTest.Services.GetServiceNamebyId(10)
+	name, err := statusPageTest.Services.GetServiceNamebyID(10)
 	assert.NoError(t, err)
 	assert.Equal(t, svc1Parent, name)
-	name, err = statusPageTest.Services.GetServiceNamebyId(11)
+	name, err = statusPageTest.Services.GetServiceNamebyID(11)
 	assert.NoError(t, err)
 	assert.Equal(t, svc1Parent+" "+svc1Child1, name)
 
@@ -145,7 +145,7 @@ func TestStatusPageEvents(t *testing.T) {
 	assert.Equal(t, 4, len(i[1]), "4 fields expected: Name, title, type and start time")
 	// Name = full service name and result is sorted by Name
 	// it should be svc3 first
-	name, _ := statusPageTest.Services.GetServiceNamebyId(31)
+	name, _ := statusPageTest.Services.GetServiceNamebyID(31)
 	assert.Equal(t, name, i[0][0], "Incidents should be sorted by name")
 	assert.Equal(t, "minor", i[0][2], "Incident Type minor")
 

pkg/storage/sos/list.go

@@ -65,7 +65,7 @@ func (c *Client) ListObjectsFunc(bucket, prefix string, recursive, stream bool)
 
 func (c *Client) ListVersionedObjectsFunc(bucket, prefix string, recursive, stream bool) listFunc[object.ObjectVersionInterface] {
 	var keyMarker *string
-	var versionIdMarker *string
+	var versionIDMarker *string
 
 	deduplicate := GetCommonPrefixDeduplicator(stream)
 
@@ -74,7 +74,7 @@ func (c *Client) ListVersionedObjectsFunc(bucket, prefix string, recursive, stre
 			Bucket:          aws.String(bucket),
 			Prefix:          aws.String(prefix),
 			KeyMarker:       keyMarker,
-			VersionIdMarker: versionIdMarker,
+			VersionIdMarker: versionIDMarker,
 		}
 
 		if !recursive {
@@ -87,7 +87,7 @@ func (c *Client) ListVersionedObjectsFunc(bucket, prefix string, recursive, stre
 		}
 
 		keyMarker = res.NextKeyMarker
-		versionIdMarker = res.NextVersionIdMarker
+		versionIDMarker = res.NextVersionIdMarker
 
 		var objects []object.ObjectVersionInterface
 		for i := range res.Versions {

pkg/storage/sos/object/object.go

@@ -30,7 +30,7 @@ type ObjectInterface interface {
 type ObjectVersionInterface interface {
 	ObjectInterface
 	GetIsLatest() bool
-	GetVersionId() *string
+	GetVersionID() *string
 	SetVersionNumber(uint64)
 	GetVersionNumber() uint64
 }
@@ -63,7 +63,7 @@ func (o *ObjectVersion) GetIsLatest() bool {
 	return o.IsLatest
 }
 
-func (o *ObjectVersion) GetVersionId() *string {
+func (o *ObjectVersion) GetVersionID() *string {
 	return o.VersionId
 }
 
@@ -82,7 +82,7 @@ func (o *Object) GetListObjectsItemOutput() *ListObjectsItemOutput {
 func (o *ObjectVersion) GetListObjectsItemOutput() *ListObjectsItemOutput {
 	out := getListObjectsItemOutput(o)
 
-	out.VersionId = o.GetVersionId()
+	out.VersionID = o.GetVersionID()
 	out.VersionNumber = &o.VersionNumber
 
 	return out

pkg/storage/sos/object/output.go

@@ -29,8 +29,8 @@ func (o *ListObjectsOutput) ToTable() {
 			_, _ = fmt.Fprintf(table, " \tDIR \t%s\n", f.Path)
 		} else {
 			version := ""
-			if f.VersionId != nil {
-				version += "\t" + *f.VersionId + "\tv" + strconv.FormatUint(*f.VersionNumber, 10)
+			if f.VersionID != nil {
+				version += "\t" + *f.VersionID + "\tv" + strconv.FormatUint(*f.VersionNumber, 10)
 			}
 			_, _ = fmt.Fprintf(table, "%s\t%6s \t%s%s\n", f.LastModified, humanize.IBytes(uint64(f.Size)), f.Path, version)
 		}
@@ -42,6 +42,6 @@ type ListObjectsItemOutput struct {
 	Size          int64   `json:"size"`
 	LastModified  string  `json:"last_modified,omitempty"`
 	Dir           bool    `json:"dir"`
-	VersionId     *string `json:"version_id"`
+	VersionID     *string `json:"version_id"`
 	VersionNumber *uint64 `json:"version_number"`
 }