Skip to content

Commit

Permalink
introduce a lint error
Browse files Browse the repository at this point in the history
  • Loading branch information
sauterp committed Jun 3, 2024
1 parent b0876ca commit f8ccea4
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions cmd/dns_show.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,10 @@ Supported output template annotations: %s`,
return errors.New("show expects one DNS domain by name or id")
}

name, err := cmd.Flags().GetString("name")
if err != nil {
return err
}
// don't merge this!!!
cmd.Flags().GetString("name")

Check failure on line 48 in cmd/dns_show.go

View workflow job for this annotation

GitHub Actions / build

Error return value of `(*github.com/spf13/pflag.FlagSet).GetString` is not checked (errcheck)

Check failure on line 48 in cmd/dns_show.go

View workflow job for this annotation

GitHub Actions / lint

Error return value of `(*github.com/spf13/pflag.FlagSet).GetString` is not checked (errcheck)

return printOutput(showDNS(args[0], name, args[1:]))
return printOutput(showDNS(args[0], "name", args[1:]))
},
}

Expand Down

0 comments on commit f8ccea4

Please sign in to comment.