Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sks: flag for CSI addon #572

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

sauterp
Copy link
Member

@sauterp sauterp commented Feb 12, 2024

Description

We add the flag --exoscale-csi to the exo compute sks create command. If set, a cluster with the CSI addon will be created. Unlike the CCM and metrics-server addons which have to be explicitly disabled with a --no-... flag, the CSI addon has to be explicitly enabled because for some users may not need it.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

❯ ./bin/exo compute sks create --exoscale-csi --zone ch-gva-2 --nodepool-size 1 my-csi-test-cluster

❯ ./bin/exo compute sks --zone ch-gva-2 show my-csi-test-cluster
┼───────────────┼──────────────────────────────────────────────────────────────────┼
│  SKS CLUSTER  │                                                                  │
┼───────────────┼──────────────────────────────────────────────────────────────────┼
│ ID            │ 7b4c6f18-58e0-4013-a351-4c9d69d4364c                             │
│ Name          │ my-csi-test-cluster                                              │
│ Description   │                                                                  │
│ Zone          │ ch-gva-2                                                         │
│ Creation Date │ 2024-02-12 17:10:35 +0000 UTC                                    │
│ Auto-upgrade  │ false                                                            │
│ Endpoint      │ https://7b4c6f18-58e0-4013-a351-4c9d69d4364c.sks-ch-gva-2.exo.io │
│ Version       │ 1.29.1                                                           │
│ Service Level │ pro                                                              │
│ CNI           │ calico                                                           │
│ Add-Ons       │ exoscale-cloud-controller                                        │
│               │ exoscale-container-storage-interface                             │
│               │ metrics-server                                                   │
│ State         │ running                                                          │
│ Labels        │ n/a                                                              │
│ Nodepools     │ n/a                                                              │
┼───────────────┼──────────────────────────────────────────────────────────────────┼

./bin/exo compute sks --zone ch-gva-2 nodepool add --size 2 my-csi-test-cluster my-csi-test-cluster-pool

❯ KUBECONFIG=kubeconfig kubectl get pods -A
NAMESPACE     NAME                                       READY   STATUS    RESTARTS   AGE
kube-system   calico-kube-controllers-558d465845-tcgb8   1/1     Running   0          18m
kube-system   calico-node-q4vps                          1/1     Running   0          7m2s
kube-system   calico-node-rvbrg                          1/1     Running   0          7m3s
kube-system   coredns-6f5866f786-f66ft                   1/1     Running   0          17m
kube-system   coredns-6f5866f786-nvfvx                   1/1     Running   0          17m
kube-system   exoscale-csi-controller-67c9d7ddb-hjsff    7/7     Running   0          17m
kube-system   exoscale-csi-controller-67c9d7ddb-pmg4z    7/7     Running   0          17m
kube-system   exoscale-csi-node-9plgw                    3/3     Running   0          6m48s
kube-system   exoscale-csi-node-c8sbg                    3/3     Running   0          6m21s
kube-system   konnectivity-agent-67467cf7b6-j4zmk        1/1     Running   0          17m
kube-system   konnectivity-agent-67467cf7b6-n5m95        1/1     Running   0          17m
kube-system   kube-proxy-77lq4                           1/1     Running   0          7m3s
kube-system   kube-proxy-v5cb7                           1/1     Running   0          7m2s
kube-system   metrics-server-8499c9d7ff-qpcxg            1/1     Running   0          17m

Copy link

This pull request has been linked to Shortcut Story #86027: CLI: SKS add CSI addon.

@sauterp sauterp marked this pull request as ready for review February 12, 2024 17:33
cmd/sks_create.go Outdated Show resolved Hide resolved
@sauterp sauterp force-pushed the philippsauter/sc-86027/cli-sks-add-csi-addon branch from 62a6166 to c979051 Compare April 2, 2024 10:03
@sauterp sauterp merged commit 897fead into master Apr 2, 2024
1 check passed
@sauterp sauterp deleted the philippsauter/sc-86027/cli-sks-add-csi-addon branch April 2, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants