Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Add more listable on Name or(not and) ID #642

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

pierre-emmanuelJ
Copy link
Member

Description

Before it was on struct with name and id, now it's with name or id.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • For a new resource or new attributes: test added/updated

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
@pierre-emmanuelJ pierre-emmanuelJ requested a review from a team July 12, 2024 16:11
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
v3/operations.go Outdated Show resolved Hide resolved
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Copy link
Member

@sauterp sauterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test it?

@pierre-emmanuelJ
Copy link
Member Author

pierre-emmanuelJ commented Jul 17, 2024

How did you test it?

I need it to my draft here, and I test it at the same time:
exoscale/cli#620

Once my change in the CLI is approved, I will merge first this one and update the CLI mod file also

@pierre-emmanuelJ
Copy link
Member Author

CSI will be fixed soon once this is merged, exoscale/exoscale-csi-driver#35

@pierre-emmanuelJ pierre-emmanuelJ merged commit 7e9b463 into master Jul 18, 2024
5 of 6 checks passed
@pierre-emmanuelJ pierre-emmanuelJ deleted the add-more-listable branch July 18, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants