Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_instance: add destroy_protected attr #337

Merged

Conversation

sauterp
Copy link
Member

@sauterp sauterp commented Feb 20, 2024

Description

We add the attribute destroy_protected to the exoscale_compute_instance resource. By default it is set to false. If the attribute is set to true the API will return an error, if an attempt is made to delete the affected instance.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Acceptance tests OK
  • For a new resource, datasource or new attributes: acceptance test added/updated

Testing

Two new acceptance tests have been added that verify the feature. The failing acceptance tests in CI are not related to this feature in any way.

Copy link

@sauterp sauterp marked this pull request as ready for review February 27, 2024 17:33
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🎉
Just missing the acceptance test to be OK, and we are good!

@sauterp sauterp merged commit 686f5a2 into master Feb 28, 2024
1 of 2 checks passed
@sauterp sauterp deleted the philippsauter/sc-89675/tf-provider-add-a-protection-flag-to-the branch February 28, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants