feat: update tests to run without need to build them before #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanovazquez
requested changes
Jul 31, 2020
| import { ExosScripts } from './common/types'; | ||
|
|
||
| export default function exosScripts(scriptName: string, args: string[]): void { | ||
| export default function exosScripts(scriptName: string): void { |
There was a problem hiding this comment.
Why are you removing the args?
There was a problem hiding this comment.
Because currently there is 2 process spawns. It should be improved but in different PR. Now I'm doing this minimum to make it possible for tests to work without prebuild.
There was a problem hiding this comment.
Usually babel, transpile, etc. is handled by Jest setup. However once we have functional unit tests, we probably will want to build for that script such as npm run test:functional or npm run test:browser.
Would a npm run test:unit without a build step be a good option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.