Fixed an issue whereby the upgrade would fail when the scripts from TimescaleDb-extras are installed. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mescaleDb-extras are installed.
expaso
added
the
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: timescale/timescaledb-extras#34
When these scripts are installed, the upgrade of the timescale extension fails with:
cannot drop _timescaledb_catalog.dimension_slice because it depends on function public.get_dimension_details(regclass)
Same error for the views: public.chunks_tstz and public.chunks_ts
This is rather nasty for me, since I don't know if users have timescaledb-extra's installed or not, and I do unsupervised upgrade.
For now, I drop these function if they exist before upgrade, but I found it worth mentioning because there may be more elegant solutions.