GetPorts: fix referencing of ports

This commit fixes the collection of ports by storing the actual item
instead of the address of the loop variable in the list. An example,
because I find pointers confusing:

Let's say our actual ports are [1, 2, 3]. Previously, GetPorts returned
[3, 3, 3], and now we receive (as expected) [1, 2, 3].

I stumbled over this problem while applying force to lbaas by having a
script create and delete services at random intervals as well as
manually deleting the lbaas and the workload pod. This should resolve
the resource leaks observed in cloudandheat#28. If we're lucky this might also help
with lbaas eating FIPs.

internal/openstack/ports.go

@@ -35,7 +35,7 @@ type UncachedClient struct {
 }
 
 type PortClient interface {
-	GetPorts() ([]*portsv2.Port, error)
+	GetPorts() ([]portsv2.Port, error)
 	GetPortByID(ID string) (*portsv2.Port, *floatingipsv2.FloatingIP, error)
 }
 
@@ -47,7 +47,7 @@ func NewPortClient(networkingclient *gophercloud.ServiceClient, tag string, useF
 	}
 }
 
-func (pc *UncachedClient) GetPorts() (ports []*portsv2.Port, err error) {
+func (pc *UncachedClient) GetPorts() (ports []portsv2.Port, err error) {
 	err = portsv2.List(
 		pc.client,
 		portsv2.ListOpts{Tags: pc.tag},
@@ -57,7 +57,7 @@ func (pc *UncachedClient) GetPorts() (ports []*portsv2.Port, err error) {
 			return false, err
 		}
 		for _, found_port := range fetched_ports {
-			ports = append(ports, &found_port)
+			ports = append(ports, found_port)
 		}
 		return true, nil
 	})