fix: use dimension as a property

experimaestro · Mar 5, 2024 · 2eaaec5 · 2eaaec5
1 parent 17936da
commit 2eaaec5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/xpmir/neural/interaction/colbert.py b/src/xpmir/neural/interaction/colbert.py
@@ -43,7 +43,7 @@ def __validate__(self):
 
     def __initialize__(self, options):
         super().__initialize__(options)
-        self.linear = nn.Linear(self.encoder.dimension(), self.linear_dim, bias=False)
+        self.linear = nn.Linear(self.encoder.dimension, self.linear_dim, bias=False)
 
     def _encode(
         self,

diff --git a/src/xpmir/text/adapters.py b/src/xpmir/text/adapters.py
@@ -16,7 +16,7 @@ def static(self):
 
     @property
     def dimension(self):
-        return self.encoder.dimension()
+        return self.encoder.dimension
 
     def forward(self, texts: List[InputType], options=None) -> RepresentationOutput:
         emb_texts = self.encoder(texts, options=options)

diff --git a/src/xpmir/text/encoders.py b/src/xpmir/text/encoders.py
@@ -245,5 +245,6 @@ def static(self):
         """Whether embeddings parameters are learnable"""
         return self.encoder.static()
 
+    @property
     def dimension(self):
-        return self.encoder.dimension()
+        return self.encoder.dimension