Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.9 #493

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Drop support for Python 3.9 #493

merged 6 commits into from
Jan 14, 2025

Conversation

jduerholt
Copy link
Contributor

This PR drops the support for Python 3.9. It will go EOL this year (https://devguide.python.org/versions/) and causes especially trouble with Entmoot but also in other occassions.

cc: @TobyBoyne @LukasHebing

@jduerholt jduerholt requested a review from bertiqwerty January 7, 2025 11:32
@jduerholt
Copy link
Contributor Author

We have here some pyright issue, the old version (1.1.305) makes problems with py3.10 and throws errors which are not really errors. Switching to newer versions produces a lot of real errors, for which I do not have currently the time to fix. I would propose to merge it as is to get rid of the entmoot problems and handle the pyright stuff seperately. Maybe somebody is also volunteering. What do you think?

Copy link
Contributor

@bertiqwerty bertiqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Agreed.

@CompRhys
Copy link
Contributor

We have here some pyright issue, the old version (1.1.305) makes problems with py3.10 and throws errors which are not really errors. Switching to newer versions produces a lot of real errors, for which I do not have currently the time to fix. I would propose to merge it as is to get rid of the entmoot problems and handle the pyright stuff seperately. Maybe somebody is also volunteering. What do you think?

I don't mind grinding through some linting errors, brainless work to do in the evening

@jduerholt
Copy link
Contributor Author

jduerholt commented Jan 14, 2025

I don't mind grinding through some linting errors, brainless work to do in the evening

Sounds great! Thanks @CompRhys. I would recommend to switch directly to the newest version then.

@jduerholt jduerholt merged commit 2af5785 into main Jan 14, 2025
9 of 10 checks passed
@jduerholt jduerholt deleted the maintenance/drop_py3.9 branch January 14, 2025 07:43
@CompRhys
Copy link
Contributor

@jduerholt Will get to this either tonight or over the weekend to try clear the linting issues

dlinzner-bcs pushed a commit that referenced this pull request Jan 20, 2025
* update tests and pyproject.toml

* update lint workflow

* update test

* bump pyright

* different pyright version

* change linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants