Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed input type of numeric options to number to avoid from the beg… #104

Closed
wants to merge 1 commit into from

Conversation

zenkavi
Copy link

@zenkavi zenkavi commented Apr 5, 2016

…inning any text input.

@vsoch
Copy link
Member

vsoch commented Apr 5, 2016

have you confirmed that this works with the material design style and js? I noticed you removed the pattern variable...

@vsoch
Copy link
Member

vsoch commented Apr 5, 2016

If you need to test, I can make the change locally, update expfactory.github.io, and then you can confirm the surveys look good - let me know.

@IanEisenberg
Copy link
Member

This change only allows numeric input to begin with. We tested in that we changed the html and confirmed that it would only allow numbers.

@IanEisenberg
Copy link
Member

That would be great! We have been testing in static html/changing the html. With this and the validation change it would be great to have a local change so I can go through and test.

@vsoch
Copy link
Member

vsoch commented Apr 5, 2016

ok, give me one sec :)

@vsoch
Copy link
Member

vsoch commented Apr 5, 2016

ok pushed, ready for you to look

@IanEisenberg
Copy link
Member

Verified for numeric questions

@vsoch vsoch closed this in ae30878 Apr 5, 2016
@vsoch
Copy link
Member

vsoch commented Apr 5, 2016

ok I'll need a minute to install on server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants