Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed testing behavior to only click one button_class button at a time #76

Merged
merged 1 commit into from
Mar 5, 2016

Conversation

IanEisenberg
Copy link
Member

No description provided.

@IanEisenberg
Copy link
Member Author

I have no idea what selenium is (a python webbrowser module?), but I believe this should just click the random button that you had already selected.

@manbat-zz
Copy link

does this actually work? I had tried something similar and I think I had my reasons for not using button.click() - I think there was a bug with selenium when I did it this way. If you are 100% sure and have tested I will merge and push to pypi, otherwise we need to maintain doing the second command (eg, button.click()) using jquery.

@manbat-zz
Copy link

This also doesn't re-select the button after the change- I don't think this works.

@IanEisenberg
Copy link
Member Author

It seemed to work when I stepped through. I can look again. An alternative is to just select a random integer in python and then use string completion to put it into a jquery call

edit: checked again. It is working fine, though I may be missing some failure point

@vsoch
Copy link
Member

vsoch commented Mar 5, 2016

It likely worked for the regular case of pushing a button. It needs to be tested with the other case of enabling a button first then pushing it (eg the hot task)

@IanEisenberg
Copy link
Member Author

Ah, of course I should have mentioned that I tested that. It seems to enable a button and then click it, no problem. It succeeds at going through the CCT_hot.

vsoch added a commit that referenced this pull request Mar 5, 2016
changed testing behavior to only click one button_class button at a time
@vsoch vsoch merged commit 7c6b99c into master Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants