Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test suite #279

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Simplify test suite #279

merged 8 commits into from
Sep 4, 2023

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Sep 1, 2023

Description

Simplify test suite to make it less dependent on the actual answers from the LLM.

  • Removed unnecessary label "DESTINATION" from the NER tests
  • Updated the "multiple-entities-with-same-string" Paris test (too difficult for the LLM to get right)
  • Updated the "correct prediction" test to be more simple & robust against odd LLM answers
  • Updated the "comma" test to be more robust

Also changed "xx" everywhere to "en" when we're testing on English sentences.

Corresponding documentation PR

NA

Types of change

test suite

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added tests Everything related to the test suite Test external Run external tests labels Sep 1, 2023
@svlandeg svlandeg mentioned this pull request Sep 1, 2023
3 tasks
@svlandeg svlandeg changed the title Simplify test sutie Simplify test suite Sep 1, 2023
@svlandeg svlandeg marked this pull request as ready for review September 1, 2023 15:50
@rmitsch rmitsch merged commit 99adb49 into develop Sep 4, 2023
@rmitsch rmitsch deleted the fix/external_tests branch September 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test external Run external tests tests Everything related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants