Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forced registration of extension by default #3

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

buhrmann
Copy link
Contributor

@buhrmann buhrmann commented Nov 14, 2018

This is to avoid ValueError: [E090] Extension 'test' already exists on Doc, in case the Emoji class is instantiated more than once in the same process.

Incidentally, this is the case in the repo's tests. Although the language object is defined as a fixture with function scope, and each function therefore receives a new copy of the language object, the instance of the Doc class used for registering the extension is shared. The tests were hence failing when repeatedly trying to register the same extension. This should be fixed now with force_extension=True by default.

@ines ines merged commit 381d20a into explosion:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants