Allow forced registration of extension by default #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid
ValueError: [E090] Extension 'test' already exists on Doc
, in case the Emoji class is instantiated more than once in the same process.Incidentally, this is the case in the repo's tests. Although the language object is defined as a fixture with function scope, and each function therefore receives a new copy of the language object, the instance of the Doc class used for registering the extension is shared. The tests were hence failing when repeatedly trying to register the same extension. This should be fixed now with
force_extension=True
by default.