Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix v8.2.4 #938

Merged
merged 17 commits into from
Jun 4, 2024
Merged

Hotfix v8.2.4 #938

merged 17 commits into from
Jun 4, 2024

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jun 3, 2024

Thinc v8.2.4

Description

  • Update typing_extensions pin
  • Update nbconvert pin
  • Update GH action versions
  • Revert macOS runner to v13 instead of latest

Types of change

Maintenance & fixes

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg marked this pull request as draft June 3, 2024 19:09
@svlandeg
Copy link
Member Author

svlandeg commented Jun 3, 2024

[MAINTENANCE NOTE]: At this point, the MacOS issues we're seeing are the same ones as we have on PR #935

[EDIT]: inspired by luigibonati/mlcolvar#129, I reverted macos-latest back to macos-13 and the tests are now green.

@svlandeg svlandeg marked this pull request as ready for review June 3, 2024 20:01
thinc/util.py Show resolved Hide resolved
@svlandeg svlandeg merged commit be0562d into v8.2.x Jun 4, 2024
30 checks passed
@svlandeg svlandeg deleted the hotfix/v8.2.4 branch June 4, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants