This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
feature: added scroll and tabWidth props #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @satya164 |
satya164
reviewed
Dec 22, 2016
| @@ -33,6 +33,8 @@ type SlidingTabItem = { | |||
| }; | |||
|
|
|||
| type Props = { | |||
| scrollEnabled?: boolean, | |||
There was a problem hiding this comment.
I think better to name it as tabBarScrollEnabled or something since you're passing it to TabNavigator. Any suggestions for a better name @brentvatne ?
There was a problem hiding this comment.
sounds like a good name to me!
There was a problem hiding this comment.
@JohnClema can update the PR to use this name instead?
There was a problem hiding this comment.
@satya164 made the changes - let me know if you think there should be any more
This was referenced Dec 26, 2016
|
Looks good to me. |
|
@satya164 @brentvatne will I need to put this into a separate branch for it to be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to have scrollable tabs and to change the width of tabs