Updated README to support newer versions of Expo SDK #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrija29 Check out my upgrades in #301. This PR should be merged along with that one. |
Great work guys! Will merge it as soon as this gets approved and your PR gets merged. |
|
Ping to merge this one now that #301 has landed! @andrija29 |
Would love to but I do not have write access to force this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Previous
README.mdfile's section about updating metro configuration was not working for newer versions of the Expo SDK.Explanation
Expo uses it's internal metro configuration that get's overridden when you have
.metro.config.jsfile in your project root folder. With the code from the previousREADME.mdfile Expo couldn't bundle the app correctly because it was missing parts of the Expo's default metro configuration.Update was made according to the official Expo documentation found here: https://docs.expo.dev/guides/customizing-metro/