Skip to content

Commit

Permalink
chore(test): remove promise support check from tests (#6148)
Browse files Browse the repository at this point in the history
Promises are supported in all supported Node.js version so the check is unnecessary
  • Loading branch information
Phillip9587 authored Nov 12, 2024
1 parent b31910c commit 9e3dbb4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions test/app.route.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
var express = require('../');
var request = require('supertest');

var describePromises = global.Promise ? describe : describe.skip

describe('app.route', function(){
it('should return a new route', function(done){
var app = express();
Expand Down Expand Up @@ -64,7 +62,7 @@ describe('app.route', function(){
.expect(404, done);
});

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
var app = express()
var route = app.route('/foo')
Expand Down
3 changes: 1 addition & 2 deletions test/app.router.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ var express = require('../')
, assert = require('assert')
, methods = require('methods');

var describePromises = global.Promise ? describe : describe.skip
var shouldSkipQuery = require('./support/utils').shouldSkipQuery

describe('app.router', function(){
Expand Down Expand Up @@ -963,7 +962,7 @@ describe('app.router', function(){
})
})

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
var app = express()
var router = new express.Router()
Expand Down

0 comments on commit 9e3dbb4

Please sign in to comment.