-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance req.acceptsCharsets method #6088
base: master
Are you sure you want to change the base?
fix: enhance req.acceptsCharsets method #6088
Conversation
Hey @Abdel-Monaam-Aouini! Thanks for this PR... can you explain the motivation for this change? |
The motivation for this change is to improve developer experience and make the Key motivations:
The changes don't break existing functionality but make the API more developer-friendly and better documented. This helps reduce potential confusion and makes the feature more accessible to new Express.js users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I think both the docs and the modernization in this are worth doing in this case.
Refactor acceptsCharsets to support flexible charset input formats
This change improves the acceptsCharsets method to handle multiple input formats:
Updates include:
The changes make the API more flexible while maintaining backwards compatibility.