refactor: res.download with lower complexity #6302
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
res.download
function to reduce complexity and improve readability while maintaining existing functionality.Changes
Object.assign
Motivation and Context
The existing implementation of
res.download
was functional but complex (with multiple nested conditions). This refactor aims to make the code more straightforward and easier to understand, which should aid in future maintenance and reduce the likelihood of bugs.How Has This Been Tested?
Additional Notes
This refactor doesn't change the function's API or behavior, so it should be a low-risk change. However, thorough review and testing are appreciated to ensure no edge cases have been overlooked☺️
By the way, I believe it is possible to refactor further, but I don't want to risk it before this pull-request