add 404 page #1690
Open
add 404 page #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carlosstenzel
approved these changes
Nov 21, 2024
chrisdel101
suggested changes
Nov 21, 2024
chrisdel101
approved these changes
Nov 21, 2024
|
btw, I couldn't find a way to translate this page into other languages, it always loaded the English version. |
|
Can someone with write permissions review it? @expressjs/docs-captains @UlisesGascon |
I don't think it makes sense to translate a 404 page, as we believe that everyone who is searching the site has some knowledge about what a 404 would be and what it means. |
UlisesGascon
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 404 page is added to stop using the default GitHub page when there is a 404 error.
Before:
after: